Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gRPC probes for Kubernetes, Openshift and Knative #882

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

Sgitario
Copy link
Collaborator

See feature request description in #857
Fix #857

Copy link
Collaborator

@aureamunoz aureamunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Shouldn't we add some doc about it? No sure if there is something about Probes but just wondering...

@Sgitario
Copy link
Collaborator Author

Sgitario commented Mar 1, 2022

LGTM! Shouldn't we add some doc about it? No sure if there is something about Probes but just wondering...

Indeed! I missed updating the documentation. I've already done it. Thanks for spotting!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sgitario Sgitario merged commit 8e292db into dekorateio:main Mar 1, 2022
@Sgitario Sgitario deleted the grpc_probes branch March 1, 2022 10:36
Sgitario added a commit to Sgitario/quarkus that referenced this pull request Mar 24, 2023
This feature was supported by Dekorate since 2.9.1 (see related PR dekorateio/dekorate#882)
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this pull request Apr 20, 2023
This feature was supported by Dekorate since 2.9.1 (see related PR dekorateio/dekorate#882)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support gRPC probes for Kubernetes, Openshift and Knative
3 participants